Improve handling of caches having discarded content #1852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the former @synchronized occasionally led to infinite locks, so I reviewed to just use @synchronized for cache updates.
This is more user friendly, by preserving the most commonly used sort orders.
Ease testing of low memory situations in unified display view
Move articles in Folder's cache only after getCompleteArticles return, so that articleController gets articles which are able to be displayed. Also mark and verify access to articles retrieved from Folder's cache.
As a convenience after the system encountered a low memory situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can assess the behavior changes by running
sudo memory_pressure -S -l critical -s 60in parallel of Vienna