Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dark mode to Credits.rtf #1215

Merged
merged 1 commit into from
Dec 30, 2018
Merged

Add support for dark mode to Credits.rtf #1215

merged 1 commit into from
Dec 30, 2018

Conversation

Eitot
Copy link
Contributor

@Eitot Eitot commented Dec 29, 2018

As suggested in the 10.14 AppKit release notes. I haven’t tested this on anything below 10.14 yet.

Supplements #1208

barijaona
barijaona previously approved these changes Dec 29, 2018
View reviewed changes
Copy link
Member

@barijaona barijaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specific issues found under 10.9.

Unrelated but worth to be mentioned here: the scrollbars are not shown by the 'About' box under 10.9.
The view is able to scroll though.

capture d ecran 2018-12-29 a 06 57 51

@Eitot Eitot merged commit 0546689 into ViennaRSS:master Dec 30, 2018
@Eitot Eitot deleted the credits branch December 30, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barijaona barijaona barijaona left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eitot @barijaona