Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual details of Mojave Theme #1208

Closed
TAKeanice opened this issue Dec 11, 2018 · 8 comments
Closed

Visual details of Mojave Theme #1208

TAKeanice opened this issue Dec 11, 2018 · 8 comments
Assignees

Comments

@TAKeanice
Copy link
Contributor

TAKeanice commented Dec 11, 2018

There are several minor graphical issues with the TabBar in the current version of Vienna under Mojave.

The overflow menu button is a little less high than the tabs next to it
bildschirmfoto 2018-12-11 um 10 55 11

The gray of the title bar and the selected tab are not the same. Also, there is no separation between the last tab and the overflow button (may be intentional)
bildschirmfoto 2018-12-02 um 23 38 53

The arrows in the overflow button seem not to have a good resolution, and the tip of the arrow points below the horizontal bar of the plus, making it look misplaced. Additionally, there is no separation between the overflow button and the plus button.
bildschirmfoto 2018-12-02 um 23 39 15

There are three grays, one gray gradient and white just next to one another, making it look not very clean but a little messy in dark mode
bildschirmfoto 2018-12-02 um 23 41 08

When switching back to light mode, or when coming from the background (both does not happen every time) some tabs seem grayed out. As soon as hovering with the mouse over them, they return to normal color.
bildschirmfoto 2018-12-02 um 23 54 31

@TAKeanice
Copy link
Contributor Author

@barijaona this could be your expert area ;)

@barijaona
Copy link
Member

barijaona commented Dec 17, 2018

Will try working on it this week. No guarantee regarding my artistic taste though ! 😸

@barijaona barijaona self-assigned this Dec 17, 2018
@barijaona
Copy link
Member

Related to MiMo42/MMTabBarView#69

@barijaona
Copy link
Member

Should be fixed by ViennaRSS/MMTabBarView#14

@Eitot
Copy link
Contributor

Eitot commented Dec 28, 2018

Also noticed that the credits in the About window are difficult to read.

@barijaona
Copy link
Member

The gray of the title bar and the selected tab are not the same.

Apparently, the intent was to mimic Safari's look on Mojave.

@stale
Copy link

stale bot commented Sep 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale ⏳ The issue will be closed 60 days after the label was added and no inactivity has occurred since. label Sep 28, 2020
@TAKeanice
Copy link
Contributor Author

I have not reviewed this any more, but since there has been work and Mojave is also not current any more, I will mark the issue resolved.

@stale stale bot removed the stale ⏳ The issue will be closed 60 days after the label was added and no inactivity has occurred since. label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants