Skip to content

Commit

Permalink
Mark several localisable strings as 'should not translate'
Browse files Browse the repository at this point in the history
  • Loading branch information
@Eitot
Eitot committed Jan 7, 2025
1 parent 1ec9bca commit e5a6ca9
Show file tree
Hide file tree
Showing 8 changed files with 56 additions and 124 deletions.
16 changes: 0 additions & 16 deletions Vienna/Interfaces/Base.lproj/InfoWindow.xib
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,6 @@
<font key="font" metaFont="systemBold"/>
<color key="textColor" name="headerTextColor" catalog="System" colorSpace="catalog"/>
<color key="backgroundColor" name="controlColor" catalog="System" colorSpace="catalog"/>
<attributedString key="userComments">
<fragment content="Do not localize">
<attributes>
<font key="NSFont" metaFont="smallSystem"/>
<paragraphStyle key="NSParagraphStyle" alignment="natural" lineBreakMode="wordWrapping" baseWritingDirection="natural" tighteningFactorForTruncation="0.0"/>
</attributes>
</fragment>
</attributedString>
</textFieldCell>
</textField>
<textField focusRingType="none" horizontalHuggingPriority="251" verticalHuggingPriority="750" preferredMaxLayoutWidth="150" translatesAutoresizingMaskIntoConstraints="NO" id="33">
Expand All @@ -74,14 +66,6 @@
<font key="font" metaFont="smallSystem"/>
<color key="textColor" name="labelColor" catalog="System" colorSpace="catalog"/>
<color key="backgroundColor" name="controlColor" catalog="System" colorSpace="catalog"/>
<attributedString key="userComments">
<fragment content="Do not localize">
<attributes>
<font key="NSFont" metaFont="smallSystem"/>
<paragraphStyle key="NSParagraphStyle" alignment="natural" lineBreakMode="wordWrapping" baseWritingDirection="natural" tighteningFactorForTruncation="0.0"/>
</attributes>
</fragment>
</attributedString>
</textFieldCell>
</textField>
<box verticalHuggingPriority="750" boxType="separator" translatesAutoresizingMaskIntoConstraints="NO" id="95">
Expand Down
77 changes: 7 additions & 70 deletions Vienna/Interfaces/Base.lproj/Preferences.storyboard
View file
Original file line number Diff line number Diff line change
Expand Up @@ -287,76 +287,13 @@
<font key="font" metaFont="menu"/>
<menu key="menu" id="Awq-ex-o9L">
<items>
<menuItem title="1" state="on" id="Byc-c2-qnN">
<attributedString key="userComments">
<fragment content="Do not localize">
<attributes>
<font key="NSFont" metaFont="menu" size="11"/>
<paragraphStyle key="NSParagraphStyle" alignment="natural" lineBreakMode="wordWrapping" baseWritingDirection="natural" tighteningFactorForTruncation="0.0"/>
</attributes>
</fragment>
</attributedString>
</menuItem>
<menuItem title="2" id="ILd-2a-Vjb">
<attributedString key="userComments">
<fragment content="Do not localize">
<attributes>
<font key="NSFont" metaFont="menu" size="11"/>
<paragraphStyle key="NSParagraphStyle" alignment="natural" lineBreakMode="wordWrapping" baseWritingDirection="natural" tighteningFactorForTruncation="0.0"/>
</attributes>
</fragment>
</attributedString>
</menuItem>
<menuItem title="5" id="aYj-Ub-Isd">
<attributedString key="userComments">
<fragment content="Do not localize">
<attributes>
<font key="NSFont" metaFont="menu" size="11"/>
<paragraphStyle key="NSParagraphStyle" alignment="natural" lineBreakMode="wordWrapping" baseWritingDirection="natural" tighteningFactorForTruncation="0.0"/>
</attributes>
</fragment>
</attributedString>
</menuItem>
<menuItem title="10" id="xjZ-nG-iOH">
<attributedString key="userComments">
<fragment content="Do not localize">
<attributes>
<font key="NSFont" metaFont="menu" size="11"/>
<paragraphStyle key="NSParagraphStyle" alignment="natural" lineBreakMode="wordWrapping" baseWritingDirection="natural" tighteningFactorForTruncation="0.0"/>
</attributes>
</fragment>
</attributedString>
</menuItem>
<menuItem title="15" id="5Y4-ws-cQJ">
<attributedString key="userComments">
<fragment content="Do not localize">
<attributes>
<font key="NSFont" metaFont="menu" size="11"/>
<paragraphStyle key="NSParagraphStyle" alignment="natural" lineBreakMode="wordWrapping" baseWritingDirection="natural" tighteningFactorForTruncation="0.0"/>
</attributes>
</fragment>
</attributedString>
</menuItem>
<menuItem title="50" id="vyo-cC-5Xv">
<attributedString key="userComments">
<fragment content="Do not localize">
<attributes>
<font key="NSFont" metaFont="menu" size="11"/>
<paragraphStyle key="NSParagraphStyle" alignment="natural" lineBreakMode="wordWrapping" baseWritingDirection="natural" tighteningFactorForTruncation="0.0"/>
</attributes>
</fragment>
</attributedString>
</menuItem>
<menuItem title="30" id="jbS-7v-rF4">
<attributedString key="userComments">
<fragment content="Do not localize">
<attributes>
<font key="NSFont" metaFont="menu" size="11"/>
<paragraphStyle key="NSParagraphStyle" alignment="natural" lineBreakMode="wordWrapping" baseWritingDirection="natural" tighteningFactorForTruncation="0.0"/>
</attributes>
</fragment>
</attributedString>
</menuItem>
<menuItem title="1" state="on" id="Byc-c2-qnN"/>
<menuItem title="2" id="ILd-2a-Vjb"/>
<menuItem title="5" id="aYj-Ub-Isd"/>
<menuItem title="10" id="xjZ-nG-iOH"/>
<menuItem title="15" id="5Y4-ws-cQJ"/>
<menuItem title="50" id="vyo-cC-5Xv"/>
<menuItem title="30" id="jbS-7v-rF4"/>
</items>
</menu>
</popUpButtonCell>
Expand Down
6 changes: 4 additions & 2 deletions Vienna/Interfaces/mul.lproj/MainMenu.xcstrings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1199,7 +1199,8 @@
"value" : "Vienna"
}
}
}
},
"shouldTranslate" : false
},
"57.title" : {
"comment" : "Class = \"NSMenu\"; title = \"Vienna\"; ObjectID = \"57\";",
Expand All @@ -1211,7 +1212,8 @@
"value" : "Vienna"
}
}
}
},
"shouldTranslate" : false
},
"58.title" : {
"comment" : "Class = \"NSMenuItem\"; title = \"About Vienna\"; ObjectID = \"58\";",
Expand Down
9 changes: 6 additions & 3 deletions Vienna/Interfaces/mul.lproj/MainWindowController.xcstrings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1295,7 +1295,8 @@
"value" : "Vienna"
}
}
}
},
"shouldTranslate" : false
},
"676-5a-TdF.title" : {
"comment" : "Class = \"NSMenuItem\"; title = \"Open Subscription Home Page\"; ObjectID = \"676-5a-TdF\";",
Expand Down Expand Up @@ -7223,7 +7224,8 @@
"value" : "Folder Name"
}
}
}
},
"shouldTranslate" : false
},
"RSJ-ph-xG6.title" : {
"comment" : "Class = \"NSButtonCell\"; title = \"0\"; ObjectID = \"RSJ-ph-xG6\";",
Expand All @@ -7235,7 +7237,8 @@
"value" : "0"
}
}
}
},
"shouldTranslate" : false
},
"sDP-Ni-g3a.title" : {
"comment" : "Class = \"NSMenuItem\"; title = \"Unread Articles\"; ObjectID = \"sDP-Ni-g3a\";",
Expand Down
35 changes: 21 additions & 14 deletions Vienna/Interfaces/mul.lproj/Preferences.xcstrings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@
}
},
"5Y4-ws-cQJ.title" : {
"comment" : "Class = \"NSMenuItem\"; title = \"15\"; ObjectID = \"5Y4-ws-cQJ\"; Note = \"Do not localize\";",
"comment" : "Class = \"NSMenuItem\"; title = \"15\"; ObjectID = \"5Y4-ws-cQJ\";",
"extractionState" : "extracted_with_value",
"localizations" : {
"en" : {
Expand All @@ -437,7 +437,8 @@
"value" : "15"
}
}
}
},
"shouldTranslate" : false
},
"6GF-Pk-gI9.title" : {
"comment" : "Class = \"NSMenuItem\"; title = \"Every 6 hours\"; ObjectID = \"6GF-Pk-gI9\";",
Expand Down Expand Up @@ -1214,7 +1215,7 @@
}
},
"aYj-Ub-Isd.title" : {
"comment" : "Class = \"NSMenuItem\"; title = \"5\"; ObjectID = \"aYj-Ub-Isd\"; Note = \"Do not localize\";",
"comment" : "Class = \"NSMenuItem\"; title = \"5\"; ObjectID = \"aYj-Ub-Isd\";",
"extractionState" : "extracted_with_value",
"localizations" : {
"en" : {
Expand All @@ -1223,7 +1224,8 @@
"value" : "5"
}
}
}
},
"shouldTranslate" : false
},
"bom-nB-4zx.title" : {
"comment" : "Class = \"NSTextFieldCell\"; title = \"Move articles to Trash:\"; ObjectID = \"bom-nB-4zx\";",
Expand Down Expand Up @@ -1472,7 +1474,7 @@
}
},
"Byc-c2-qnN.title" : {
"comment" : "Class = \"NSMenuItem\"; title = \"1\"; ObjectID = \"Byc-c2-qnN\"; Note = \"Do not localize\";",
"comment" : "Class = \"NSMenuItem\"; title = \"1\"; ObjectID = \"Byc-c2-qnN\";",
"extractionState" : "extracted_with_value",
"localizations" : {
"en" : {
Expand All @@ -1481,7 +1483,8 @@
"value" : "1"
}
}
}
},
"shouldTranslate" : false
},
"c4l-M5-qB1.title" : {
"comment" : "Class = \"NSMenuItem\"; title = \"After one day\"; ObjectID = \"c4l-M5-qB1\";",
Expand Down Expand Up @@ -3446,7 +3449,7 @@
}
},
"ILd-2a-Vjb.title" : {
"comment" : "Class = \"NSMenuItem\"; title = \"2\"; ObjectID = \"ILd-2a-Vjb\"; Note = \"Do not localize\";",
"comment" : "Class = \"NSMenuItem\"; title = \"2\"; ObjectID = \"ILd-2a-Vjb\";",
"extractionState" : "extracted_with_value",
"localizations" : {
"en" : {
Expand All @@ -3455,7 +3458,8 @@
"value" : "2"
}
}
}
},
"shouldTranslate" : false
},
"ITA-U9-lhX.title" : {
"comment" : "Class = \"NSTextFieldCell\"; title = \"Article list font:\"; ObjectID = \"ITA-U9-lhX\";",
Expand Down Expand Up @@ -3584,7 +3588,7 @@
}
},
"jbS-7v-rF4.title" : {
"comment" : "Class = \"NSMenuItem\"; title = \"30\"; ObjectID = \"jbS-7v-rF4\"; Note = \"Do not localize\";",
"comment" : "Class = \"NSMenuItem\"; title = \"30\"; ObjectID = \"jbS-7v-rF4\";",
"extractionState" : "extracted_with_value",
"localizations" : {
"en" : {
Expand All @@ -3593,7 +3597,8 @@
"value" : "30"
}
}
}
},
"shouldTranslate" : false
},
"jfH-Hq-gRk.title" : {
"comment" : "Class = \"NSButtonCell\"; title = \"Bounce the application icon\"; ObjectID = \"jfH-Hq-gRk\";",
Expand Down Expand Up @@ -6308,7 +6313,7 @@
}
},
"vyo-cC-5Xv.title" : {
"comment" : "Class = \"NSMenuItem\"; title = \"50\"; ObjectID = \"vyo-cC-5Xv\"; Note = \"Do not localize\";",
"comment" : "Class = \"NSMenuItem\"; title = \"50\"; ObjectID = \"vyo-cC-5Xv\";",
"extractionState" : "extracted_with_value",
"localizations" : {
"en" : {
Expand All @@ -6317,7 +6322,8 @@
"value" : "50"
}
}
}
},
"shouldTranslate" : false
},
"wyk-W1-xMh.title" : {
"comment" : "Class = \"NSViewController\"; title = \"Updates\"; ObjectID = \"wyk-W1-xMh\";",
Expand Down Expand Up @@ -6578,7 +6584,7 @@
}
},
"xjZ-nG-iOH.title" : {
"comment" : "Class = \"NSMenuItem\"; title = \"10\"; ObjectID = \"xjZ-nG-iOH\"; Note = \"Do not localize\";",
"comment" : "Class = \"NSMenuItem\"; title = \"10\"; ObjectID = \"xjZ-nG-iOH\";",
"extractionState" : "extracted_with_value",
"localizations" : {
"en" : {
Expand All @@ -6587,7 +6593,8 @@
"value" : "10"
}
}
}
},
"shouldTranslate" : false
},
"YG6-9k-gKH.title" : {
"comment" : "Class = \"NSTextFieldCell\"; title = \"URL:\"; ObjectID = \"YG6-9k-gKH\";",
Expand Down
9 changes: 6 additions & 3 deletions Vienna/Resources/InfoPlist.xcstrings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"value" : "Vienna"
}
}
}
},
"shouldTranslate" : false
},
"NSAppleEventsUsageDescription" : {
"comment" : "A message that tells the user why Vienna is requesting the ability to send Apple events.",
Expand All @@ -22,7 +23,8 @@
"value" : ""
}
}
}
},
"shouldTranslate" : false
},
"NSHumanReadableCopyright" : {
"comment" : "Copyright (human-readable)",
Expand All @@ -34,7 +36,8 @@
"value" : "© 2004–2024 The Vienna RSS Project"
}
}
}
},
"shouldTranslate" : false
},
"OPML document" : {
"comment" : "A label for OPML (Outline Processor Markup Language) documents. This is shown in Finder's Get Info window, for example.",
Expand Down
12 changes: 2 additions & 10 deletions Vienna/Resources/Localizable.xcstrings
View file
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,8 @@
"value" : "%1$@, %2$@"
}
}
}
},
"shouldTranslate" : false
},
"%d new articles retrieved" : {
"localizations" : {
Expand Down Expand Up @@ -8268,9 +8269,6 @@
}
}
},
"Development Options" : {
"comment" : "Do not localize"
},
"Do not show this warning again" : {
"comment" : "Title of a checkbox on an alert",
"localizations" : {
Expand Down Expand Up @@ -13647,12 +13645,6 @@
}
}
},
"Log Formatting Strings" : {
"comment" : "Do not localize"
},
"Log Predicate String" : {
"comment" : "Do not localize"
},
"Make sure the username and password needed to access the Open Reader server are correctly set in Vienna's preferences. Also check your network access." : {
"localizations" : {
"da" : {
Expand Down
16 changes: 10 additions & 6 deletions Vienna/Sources/Alerts/SmartFolder.m
View file
Original file line number Diff line number Diff line change
Expand Up @@ -337,14 +337,18 @@ - (void)prepareDevelopmentOptionsButton
{
NSPopUpButton *button = [[NSPopUpButton alloc] initWithFrame:NSZeroRect
pullsDown:YES];
[button addItemWithTitle:NSLocalizedString(@"Development Options",
@"Do not localize")];
[button.menu addItemWithTitle:NSLocalizedString(@"Log Predicate String",
@"Do not localize")
NSBundle *mainBundle = NSBundle.mainBundle;
[button addItemWithTitle:[mainBundle localizedStringForKey:@"Development Options"
value:nil
table:nil]];
[button.menu addItemWithTitle:[mainBundle localizedStringForKey:@"Log Predicate String"
value:nil
table:nil]
action:@selector(logPredicateString)
keyEquivalent:@""];
[button.menu addItemWithTitle:NSLocalizedString(@"Log Formatting Strings",
@"Do not localize")
[button.menu addItemWithTitle:[mainBundle localizedStringForKey:@"Log Formatting Strings"
value:nil
table:nil]
action:@selector(logFormattingStrings)
keyEquivalent:@""];
button.translatesAutoresizingMaskIntoConstraints = NO;
Expand Down

0 comments on commit e5a6ca9

Please sign in to comment.