re-position Request.Format check after CSR handling, based on PR comm…

…ents
Venafi · Mar 27, 2023 · c6f37f7 · c6f37f7
1 parent 1d7d42b
commit c6f37f7
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/pkg/venafi/tpp/connector.go b/pkg/venafi/tpp/connector.go
@@ -1202,11 +1202,6 @@ func (c *Connector) RetrieveCertificate(req *certificate.Request) (certificates
 	includeChain := req.ChainOption != certificate.ChainOptionIgnore
 	rootFirstOrder := includeChain && req.ChainOption == certificate.ChainOptionRootFirst
 
-	// if Request doesn't contain a Format, use defaults
-	if req.KeyType == certificate.KeyTypeRSA {
-		req.Format = certificate.CertFormatBase64PKCS8
-	}
-
 	if req.PickupID == "" && req.Thumbprint != "" {
 		// search cert by Thumbprint and fill pickupID
 		searchResult, err := c.searchCertificatesByFingerprint(req.Thumbprint)
@@ -1234,6 +1229,11 @@ func (c *Connector) RetrieveCertificate(req *certificate.Request) (certificates
 		certReq.Password = req.KeyPassword
 	}
 
+	// if Request doesn't contain a Format, use defaults
+	if req.KeyType == certificate.KeyTypeRSA {
+		req.Format = certificate.CertFormatBase64PKCS8
+	}
+
 	startTime := time.Now()
 	for {
 		var retrieveResponse *certificateRetrieveResponse