Enables adding a custom timeout for requests. Fixes bug for current server timeout role attribute #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibute -server_timeout as doing TypeInt vs TypeSeconds and current duration conversion led to unexpect value be saved in role entry. Also adds the value to be returned in role read operation response
luispresuelVenafi
requested review from
rvelaVenafi,
marcos-albornoz and
EduardoVV
as code owners
rvelaVenafi
approved these changes
Feb 28, 2024
rvelaVenafi
requested changes
Feb 28, 2024
…t by usin Timeout from request wrapper. Changes validations to only accept positive values for timeout
marcos-albornoz
approved these changes
Feb 28, 2024
rvelaVenafi
requested changes
Feb 29, 2024
rvelaVenafi
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server_timeoutattribute for role entry.server_timeoutattribute in response when role attributes are displayed in read operation.