Applying RG to entire river networks and other changes from GRIT #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aph to multiple network components.
… inlets to only to randomly selected outlets.
…river directionality to standard rivgraph.
…essing successively and others. Used for GRITv0.2.
…ing links and better links finding.
…ise uncertain links will be reset.
…s with inlets and outlets can be resolved topologically with fix_cycle_inlet_outlet.
…inks, finds path out of sink and then assigns directions. Also set all remaining (previously randomly assigned links) via shortest path to outlet.
|
Exciting @mwort! Looking forward to seeing the individual features as you get a chance to split them out into more bite-sized PRs. |
|
@mwort Congrats on getting to a stable point! I am wondering if it would make sense to set up another meeting for you to catch us up on your improvements. I am pretty swamped until May, but if that sounds good to you, shoot me/us an email and we'll arrange a time. Looks like some cool functionality and it would be great if we could merge as much as possible. I'm hoping @jsta and @elbeejay will be able to help with this as well. Not sure what you're thinking w.r.t. publication, but we'd be open to something collaborative like RG 2.0. Just something to think about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jonschwenk ,
I'm finally sharing the code changes from my Global River Topology (GRIT) work, after presenting this to you guys in May 2023. This PR is not actually meant to be merged as is, but is mainly intended to show you some of the changes I needed to make for GRIT. It will probably make most sense to create separate branches and PRs for more granular changes, e.g. for the
directionality.py:set_width_continuityalgorithm or therivgraph/networkssubpackage (which likely violates many of the design decisions taken for the rest of the repo and duplicates some code from the other modules). Note that all of the raster processing for GRIT was done in GRASS outside of RG which the input parsed to thenetworks.RiverNetworkclass. That made some defaults and bypassing of the river mask processing necessary.Hope this helps. Happy to discuss of course.