Skip to content

Commit

Permalink
Update contributors.properties
Browse files Browse the repository at this point in the history
  • Loading branch information
@Vazkii
Vazkii authored Aug 15, 2023
1 parent 39f1185 commit a284bd5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions contributors.properties
View file
Original file line number Diff line number Diff line change
Expand Up @@ -266,3 +266,6 @@ aedricprince=#d06dff,#3cfcdc,#fc993c,#dbff14,#ff2d77,#f3f9bb,#d295d8
waerr=#FF0000
jdpaboojian=#008800
eliteminecraft99=#000000,#ff1744,#ea80fc
kevinkebab=#e9a9e8

kevinkebab=5

1 comment on commit a284bd5

@rshchekotov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Vazkii - just wanted to let you know that this change (which is still there in the current master [which is at 629a668]) silently crashes here:

Psi/src/main/java/vazkii/psi/common/core/handler/ContributorSpellCircleHandler.java

Line 46 in 629a668

int[] values = Stream.of(value.split(",")).mapToInt(el -> Integer.parseInt(el.substring(2), 16)).toArray();

during Mod Loading.

You expect Hex Numbers there, that's the idea behind the Integer.parseInt(el.substring(2), 16) I suppose at least.
So I assume that line 271 of this change (or line 270 in current master) is a mistake?
If it isn't then you should probably rework the parsing logic based on whether a # is found or not.

Thanks for your hard work!
(Should an issue be helpful I'll create one - especially in the event this should go unnoticed)

Please sign in to comment.