Refactor Card component #180
Conversation
mks-h
force-pushed
the
card
branch
3 times, most recently
from
ff92a32 to
1125759
Compare
|
The "adv" type of Card uses a pair of
Other types of cards use Edit: The illustration doesn't actually use the Card component, but the point stands for both. |
|
Mmh that looks an oversight by me. Yes, your solution is fine. |
|
There's some visual change with the new h3 adv cards, which I think is fine if not better: Old VS New
In context:Old
New:
Old:
New:
|
|
I like the new margins |
mks-h
force-pushed
the
card
branch
3 times, most recently
from
ab54153 to
0cac8b1
Compare
mks-h
force-pushed
the
card
branch
4 times, most recently
from
1668a82 to
42c7054
Compare
A class of "badges-item--undefined" is no longer set if the badge color is undefined.
If title of a footer action is not provided (like at "/team"), an empty "span" element for it is no longer rendered.
Only renders "card actions" if the card is either "clickable" or has "actions" property set. Notice that there is currently no use of the "actions" property.
Card component has both "image" and "icon" properties to specify the source, and "imageAsIcon" makes it sound like "image" source will be used for an icon, while it is the other way around.
Instead of "title2" property, use array of 2 strings with the "title" property. If multiline title is used, alt text now joins lines with a space, instead of using the first line.
CardContent's link now supports external links for "adv" button. If no link is provided for "adv" button, a "div" will render instead of href-less "a" tag. This scenario isn't used, and would likely be a bug.
The ".card--has-actions" class is removed as it should always be used at the same time as ".card--clickable". Uses of the ".card-action" class are removed, as it is not defined or used in css.
There's some visual change, such as the pronounced part of the title is bigger, and space between a multiline string is smaller (as it is a single string now).
In DownloadOrchidBeta, replace manual card with the Card component.
|
I have refactored the Card component to a certain degree. There's no immediate gain from it, apart from previously mentioned use of |
The Card component practically has 4 copies of its content with minor variations, so I have started refactoring it.