Draft: Replace custom merge function with EtcBuilder #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a custom merge function, abroot will use EtcBuilder from linux-immutability-tools to handle multiple etc directories properly.
|
Didn’t tested it yet but the implementation looks good. |
|
This unveiled an issue in the installer that caused it to modify the system etc, causing EtcBuilder not to work. I am not sure if that issue has been fixed yet, but I wasn't able to test if it works. |
|
I am not sure, @matbme did some changes to the installer recently |
|
setting up a vm to test this and #72 (I don't think I have the time this evening, for sure this weekend) |
|
This pr is so old its easier to just open a new one based on the latest changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a custom merge function, abroot will use EtcBuilder from linux-immutability-tools to handle multiple etc directories properly.
This will require changes in the vanilla os base image.
I have also not tested these changes yet.