-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat [close #310]: Mounts system mountpoints like /home and /etc before systemd starts #316
Conversation
Also, I can squash the commits if it's necessary but I think these commits are already pretty atomic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good. My spam of suggestions is mostly related to missing translations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I agree with Mat about the missing translations, but per our conversation on discord, should be fine due to the command being strictly internal.
Anyway, adding the translation keys should not be so hard, so I'll leave the decision to you.
Since abroot now handles mounting before systemd, this is not required anymore.
fe99043
to
5f17d0b
Compare
As discussed on Discord, I don't want to put translations in. |
Not to go over Mat but given the discussions on Discord regarding the translations and given the resolution of the discussions, I still proceed with the merge without his confirmation. |
Fixes #310
This command replaces the systemd mount units with a command that has to be run before systemd.
This ensures that systemd recognizes the correct state of /etc.
This also makes the system more predictable, since there's not two different /etc folders to worry about.
To migrate to this version, the init system has to call the two new abroot functions before executing systemd.
The systemd mount units of old abroot versions don't cause any problems, since systemd doesn't remount them, so no futher migration is needed.