fix: image's etc changes not being applied #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix: Vanilla-Kattleya/plasma-image#10
The problem I was facing is the
sddmuser not being added to/var/lib/abroot/etc/vos-b/passwd. I did the process manually by diffing and patching bothpasswdfiles, then I found the changes were not being applied due to the-Rflag being present, here the manpage:by removing the flag, the changes got merged to
/var/lib/abroot/etc/vos-b/passwd. Not sure if this ever worked before, I did some tests at the time but I forgot to document why I added the-Rflag.I need feedback and another test, perhaps using a different image, I am using the KDE image) on this before merging. The binary for testing will be available as an artifact once https://github.com/Vanilla-OS/ABRoot/actions/runs/7972020941 completes.