Patch buffers #142
Closed
Patch buffers #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkaukov
commented
Dec 20, 2024
| @@ -837,7 +839,7 @@ public void onRunError(Exception e) { | |||
| } | |||
| }); | |||
| usbIoManager.setWriteBufferSize(90000); // Must be large enough that ESP32 can take its time accepting our bytes without overrun. | |||
| usbIoManager.setReadBufferSize(4096); // Must be much larger than ESP32's send buffer (so we never block it) | |||
| usbIoManager.setReadBufferSize(1024); // Must be much larger than ESP32's send buffer (so we never block it) | |||
| @@ -667,7 +669,7 @@ private void initAudioTrack() { | |||
| .setChannelMask(AudioFormat.CHANNEL_OUT_MONO) | |||
| .build()) | |||
| .setTransferMode(AudioTrack.MODE_STREAM) | |||
| .setBufferSizeInBytes(rxMinBufferSize) | |||
| .setBufferSizeInBytes(1024 * 3) | |||
| @@ -128,7 +129,8 @@ public class RadioAudioService extends Service { | |||
|
|
|||
| // For receiving audio from ESP32 / radio | |||
| private AudioTrack audioTrack; | |||
| private static final int PRE_BUFFER_SIZE = 1000; | |||
| private static int audioTrackUnderrunCount = 0; | |||
| private static final int PRE_BUFFER_SIZE = 1024 * 2; | |||
|
Closing in favor of #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config seems to prevent buffer underruns.
Related to the #140
-Buffer is 3x chunk size
-We priming it with 2 chunks