Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit test for error handling. #9

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Med16-11
Copy link

@Med16-11 Med16-11 commented Mar 9, 2023

Hello mentors ! @kamoltat @zmc @amathuria
I have added a unit test for error handling as mentioned in task 2 for Outreachy applicant.
Please review the PR and let me know the changes that are required. Thank you.

Copy link
Collaborator

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests for 2 functions of your choice, 1 in src/services/suite.py and 1 in src/services/kill.py. Also, please sign your commit using: git commit -s. Great work!

@Med16-11
Copy link
Author

Sure will do that ! Thanks for suggestions.

@Med16-11
Copy link
Author

Done @kamoltat . I will now start working on the recommended unit cases.

@Med16-11
Copy link
Author

@kamoltat @amathuria I have completed by second task.

@Med16-11
Copy link
Author

Hello mentors @kamoltat @amathuria
Since this pull request has Outreachy-GSOC tag, I am sharing my task 3 progress here.
Link to my work : https://www.figma.com/file/kNoUOdAjEhSnA9kRsd833g/Untitled?node-id=0%3A1&t=9QzqIerFQcFmORRX-1

Screenshot

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants