Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for API endpoints using TestClient library from fast-api #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Dorcas-BD
Copy link

Added unit tests for API endpoints using FastAPI's TestClient library to ensure correct responses and improve application quality. Used TestClient to make HTTP requests, wrote test functions for various use cases and checked for correct status codes, headers, and response bodies. Please review @amathuria @kamoltat @zmc

Copy link
Collaborator

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a unit-test for 1 func in src/services/kill.py

@kamoltat
Copy link
Collaborator

Please also sign your commit using git commit -s

@Dorcas-BD
Copy link
Author

Please also add a unit-test for 1 func in src/services/kill.py

Alright, I will do that @kamoltat

Dorcas Bamisile and others added 2 commits March 21, 2023 06:35
@Dorcas-BD
Copy link
Author

Dorcas-BD commented Mar 24, 2023

Hello @kamoltat, I wanted to let you know that I've added unit tests for src/services/kill.py and signed my commit. Can you please review it?

@Dorcas-BD Dorcas-BD requested a review from kamoltat March 25, 2023 11:46
@Dorcas-BD
Copy link
Author

Hello @kamoltat,

I have pushed a commit for my Task 3. Please review it and provide me with your feedback or suggestions. Additionally, if you haven't had a chance to review my Task 2 yet, please also look at that.

Thank you in advance for your help.

cc: @amathuria @zmc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants