Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing if zipping whole directory instead of asterisk helps with the… #418

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KarthikMasi
Copy link
Contributor

… 'argument list too long' problem. @baxpr this is very much in testing. Not ready for pulling yet. Pull request for the sake of having conversations.

@KarthikMasi KarthikMasi requested a review from baxpr March 13, 2023 23:57
@baxpr
Copy link
Member

baxpr commented Mar 14, 2023

Sounds like that might do it yeah. I can test in the context of the workflow I'm working on

@KarthikMasi
Copy link
Contributor Author

The extraction of the zip file on XNAT's side failed with this. I am trying an alternate approach using find and piping to zip. Will push that once my test is done.

@KarthikMasi
Copy link
Contributor Author

My uploads are slow but the tests are on-going

@baxpr
Copy link
Member

baxpr commented Mar 14, 2023

FYI we can't assume anything about filenames (like *.dcm). If you settle on the find strategy it needs to be something like find ${dir} -type f. But you may also be able to use the dir name in the zip command line instead of filenames (*).

@bud42 bud42 marked this pull request as draft June 15, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants