Merge show-pupil branch with other minor edits #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tknapen
approved these changes
Dec 17, 2022
|
I got it to work with python 3.9 on Mac (Ventura 13.0.1). Lots of issues with What errors are you getting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've always been using the
show_pupil-branch from @Gilles86's fork. as it nicely shows the eye on the screen during set up. We've also encountered some other minor issues (such as @iverissimo's issue [#24]). This pull request combines all these changes.Would be good to eventually sync up again, making it hard to see the forest through the all the branches that are available.