Issue/3179 #3180
Merged
Issue/3179 #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schandrika
reviewed
May 6, 2024
Handle behavior of removing PersistentDict
|
So this still requires the wide open on_any_event, or this works with on_closed? |
|
Works with on closed |
|
I will do an updated pr to 8.2 soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #3179 by removing the PersistentDict from the admin_endpoint.py file. This file is responsible for initiating the creation of the web admin user. The syncing of the persistent dictionary to disk caused issues with the watchdog reloader.
This fix should be able to be merged with releases/8.2 branch
Fixes #3179
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tests are in the process of running, and have run locally in order to verify the expected results.
Checklist: