Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSL verification for Home Assistant #3152

Closed
wants to merge 3 commits into from
Closed

SSL verification for Home Assistant #3152

wants to merge 3 commits into from

Conversation

riley206
Copy link
Contributor

Description

Updated Home Assistant driver to allow for SSL verification with the option of a self signed local certificate.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Ran on main, develop and 9.x

  • Test A
  • Test B

Test Configuration:

  • Ubuntu 22.04.3 LTS
  • WSL

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 19, 2024
View reviewed changes
services/core/PlatformDriverAgent/platform_driver/interfaces/home_assistant.py
else:
self.verify_option = self.verify_ssl

_log.info(f"using verify option: {self.verify_option}")

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (certificate)
Loading
as clear text.
This expression logs
sensitive data (certificate)
Loading
as clear text.
@riley206 riley206 closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@riley206