Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: フルコンテキストラベルの見通し改善 #926

Merged
merged 4 commits into from
Dec 25, 2023

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Dec 23, 2023

内容

フルコンテキストラベルの見通し改善

full_context_label.py はリファクタリングが進行中であるが、関数ネストなどいくつかの積み残しがある。
またそのテストコードには未リネームのテストが複数残存している。
よって、フルコンテキストラベル関係のリファクタリングを提案します。

以下のリファクタリングを実行:

  • _extract_utterance_label() の廃止(ネストの排除)
  • テストリネーム

関連 Issue

close #881 (final step 🎉)

@tarepan tarepan requested a review from a team as a code owner December 23, 2023 10:56
@tarepan tarepan requested review from Hiroshiba and removed request for a team December 23, 2023 10:56
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 487 329 coverage-32%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/cancellable_engine.py 91 71 coverage-22%
voicevox_engine/core_wrapper.py 222 157 coverage-29%
voicevox_engine/dev/core/init.py 2 0 coverage-100%
voicevox_engine/dev/core/mock.py 22 5 coverage-77%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 42 3 coverage-93%
voicevox_engine/engine_manifest/EngineManifest.py 34 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 3 0 coverage-100%
voicevox_engine/library_manager.py 93 5 coverage-95%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 18 6 coverage-67%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 162 9 coverage-94%
voicevox_engine/morphing.py 70 46 coverage-34%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 81 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 18 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/tts_pipeline/init.py 5 0 coverage-100%
voicevox_engine/tts_pipeline/acoustic_feature_extractor.py 25 1 coverage-96%
voicevox_engine/tts_pipeline/full_context_label.py 125 5 coverage-96%
voicevox_engine/tts_pipeline/kana_parser.py 86 1 coverage-99%
voicevox_engine/tts_pipeline/make_tts_engines.py 58 30 coverage-48%
voicevox_engine/tts_pipeline/mora_list.py 4 0 coverage-100%
voicevox_engine/tts_pipeline/tts_engine.py 215 26 coverage-88%
voicevox_engine/tts_pipeline/tts_engine_base.py 58 9 coverage-84%
voicevox_engine/user_dict.py 144 12 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 10 0 coverage-100%
voicevox_engine/utility/path_utility.py 35 9 coverage-74%
TOTAL 2247 727 coverage-68%

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

とても綺麗になったと思います、ありがとうございます!!!

@Hiroshiba Hiroshiba merged commit 3ac4410 into VOICEVOX:master Dec 25, 2023
3 checks passed
@tarepan tarepan deleted the refactor/simple_fcl branch December 25, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: OpenJTalkドメインの隔離
2 participants