Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: 合成系のコア直接呼び出しを TTSEngine へ移動 #1420

Merged
merged 9 commits into from
Jun 25, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Jun 23, 2024

内容

#1391 に従い、合成に関するコアの直接呼び出しを TTSEngine 経由へ変更するリファクタリングを提案します。

本 PR は移動に特化しています。

test_missing_core_422().get_core() のエラーを確認するテストです。本 PR の変更により .get_core() を呼び出す API が減ったため、変わらず .get_core() を呼び出している API をテストに使うよう変更しました。

関連 Issue

part of #1391

@tarepan tarepan requested a review from a team as a code owner June 23, 2024 06:45
@tarepan tarepan requested review from Hiroshiba and removed request for a team June 23, 2024 06:45
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit 75314de into VOICEVOX:master Jun 25, 2024
4 checks passed
@tarepan tarepan deleted the refactor/wide_tts_engine branch June 25, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants