refactor: VVMマニフェストで#[serde(flatten)]を活用
#891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
force-pushed
the
refactor-use-serde-flatten-for-vvm-manifest
branch
2 times, most recently
from
3168837 to
a9cb5e1
Compare
qryxip
force-pushed
the
refactor-use-serde-flatten-for-vvm-manifest
branch
from
a9cb5e1 to
a8e3713
Compare
|
前提がわかっていないのですが、 #825 がdraftだけどこっちだけでレビューして良い感じでしょうか？ 👀 |
|
はい。よくない表現だった。 #825 と合わせたときに綺麗なコードになることをイメージしています。 [追記] 綺麗なコードになるというのは具体的には、 |
|
ああなるほど！！ |
qryxip
added a commit
to qryxip/voicevox_core
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#825 を前提としたリファクタ。
関連 Issue
その他
別リポジトリでVVMマニフェストを触っていて思い付きました。