Streaming decoder for compatible engine #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
reviewed
Nov 20, 2024
qryxip
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- crates/test_util/compatible_engine.h: Language not supported
Comments skipped due to low confidence (2)
crates/voicevox_core_c_api/tests/e2e/testcases/compatible_engine.rs:87
- [nitpick] The variable name 'wave2' is ambiguous. It should be renamed to 'intermediate_wave'.
let wave2 = {
crates/voicevox_core_c_api/tests/e2e/testcases/compatible_engine.rs:116
- [nitpick] The variable name 'wave3' is ambiguous. It should be renamed to 'chunked_wave'.
let wave3 = {
Hiroshiba
reviewed
Nov 22, 2024
crates/voicevox_core_c_api/tests/e2e/testcases/compatible_engine.rs
Outdated
Show resolved
Hide resolved
Hiroshiba
reviewed
Nov 25, 2024
Comment on lines
386
to
385
| let margin_width = margin_width as usize; | ||
| let feature_dim = feature_dim as usize; | ||
| const MARGIN_WIDTH: usize = 14; | ||
| const FEATURE_SIZE: usize = 80; |
There was a problem hiding this comment.
こことその下に書かれてるアサート処理はこの関数に独自に追加された処理ですが、個人的にはそのままでもだけしてもどちらでも良さそうに思っています。
@qryxip さんにお任せできれば！
There was a problem hiding this comment.
私がsuggestしたやつですね。他の関数も後でこれで統一しようかなと。
ちなみにassert!じゃなくif … { panic!(…); }としたのは、私の理解では出力サイズはONNXモデル次第だからですね。Rust API側での保証はしてなかったはず？
|
LGTM、なのですがCIがちょうど色々ぶっ壊れてますね。 |
|
上記の三点は直ったのですが、別の理由でうっかりmainブランチのCIを壊してしまったので #877 を先にマージしたく… |
qryxip
added a commit
to qryxip/voicevox_core
that referenced
this pull request
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ストリーミング処理をC APIとして実装
testcaseとして一括変換・ストリーム変換の二つの生成結果を追加し、元の生成音声と比較して十分近いことを確かめた
関連 Issue
close #866