Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cstr!("…")c"…"に置き換える #782

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Apr 15, 2024

内容

synをdtolnay/syn#1622入りのv2.0.59に上げ、cstr!("…")をすべてc"…"に置き換えます。

関連 Issue

その他

Cargo.toml Outdated Show resolved Hide resolved
@qryxip qryxip marked this pull request as draft April 15, 2024 17:35
@qryxip
Copy link
Member Author

qryxip commented Apr 15, 2024

cbindgenが最新版でもsyn v1の方を使っとる (嘘でしょ…)

@qryxip
Copy link
Member Author

qryxip commented Jun 11, 2024

お、これでcbindgenのリリースがされれば可能になる。
mozilla/cbindgen@aa8ea65

@qryxip
Copy link
Member Author

qryxip commented Oct 12, 2024

cbindgen v0.27.0が8月に出てたっぽい。GitHub Releaseには出されてなかったので通知が来ずに気づかなかった。

qryxip added a commit that referenced this pull request Oct 13, 2024
以下のクレートのバージョンを上げ、`cargo deny check advisories`が通るよ
うにする。

- cbindgen v0.24.3 → v0.27.0
- duplicate v1.0.0 → v2.0.0
- h2 v0.3.15 (transitive only) → v0.3.26
- reqwest v0.11.13 → v0.11.27
- rustls v0.21.7 (transitive only) → v0.21.11
- shlex v1.1.0 (transitive only) → v1.3.0

cbindgenだけ必要最低限を超えて最新版までアップデートしているが、これはこ
の後すぐ #782 をやりたいため。
@qryxip qryxip marked this pull request as ready for review October 13, 2024 11:48
@qryxip qryxip requested a review from Hiroshiba October 13, 2024 11:49
@qryxip qryxip changed the title cstr!("…")c"…"に置き換える chore: cstr!("…")c"…"に置き換える Oct 13, 2024
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@qryxip qryxip changed the title chore: cstr!("…")c"…"に置き換える refactor: cstr!("…")c"…"に置き換える Oct 14, 2024
@qryxip qryxip merged commit 683da55 into VOICEVOX:main Oct 14, 2024
34 checks passed
@qryxip qryxip deleted the use-c-string-literal branch October 14, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants