-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cstr!("…")
をc"…"
に置き換える
#782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Apr 15, 2024
Merged
cbindgenが最新版でもsyn v1の方を使っとる (嘘でしょ…) |
お、これでcbindgenのリリースがされれば可能になる。 |
5 tasks
cbindgen v0.27.0が8月に出てたっぽい。GitHub Releaseには出されてなかったので通知が来ずに気づかなかった。 |
qryxip
added a commit
that referenced
this pull request
Oct 13, 2024
以下のクレートのバージョンを上げ、`cargo deny check advisories`が通るよ うにする。 - cbindgen v0.24.3 → v0.27.0 - duplicate v1.0.0 → v2.0.0 - h2 v0.3.15 (transitive only) → v0.3.26 - reqwest v0.11.13 → v0.11.27 - rustls v0.21.7 (transitive only) → v0.21.11 - shlex v1.1.0 (transitive only) → v1.3.0 cbindgenだけ必要最低限を超えて最新版までアップデートしているが、これはこ の後すぐ #782 をやりたいため。
sevenc-nanashi
approved these changes
Oct 13, 2024
Hiroshiba
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
synをdtolnay/syn#1622入りのv2.0.59に上げ、
cstr!("…")
をすべてc"…"
に置き換えます。関連 Issue
その他