Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_utilクレートをdev-dependencies #659

Closed
wants to merge 2 commits into from

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Oct 26, 2023

内容

Python APIからのtest_utilクレートの依存を、他に合わせてdependenciesからdev-dependenciesに移します。

https://penguin.fanbox.cc/posts/6211928

関連 Issue

その他

@qryxip qryxip mentioned this pull request Oct 26, 2023
@qryxip qryxip requested a review from Hiroshiba October 26, 2023 14:36
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

今回はmanylinuxで必要になるライブラリがdev onlyだった感じですが、今後はちょっとした制約になるかもですねぇ。

@qryxip
Copy link
Member Author

qryxip commented Oct 26, 2023

あ! なるほど...

https://github.com/VOICEVOX/voicevox_core/actions/runs/6655691778/job/18086507610?pr=659

@qryxip
Copy link
Member Author

qryxip commented Oct 26, 2023

どうするべきか悩みますね... Java APIの方も、たまたまcargo buildが必要だからtest_utilのビルドを通る形になってますし。

- name: Build
run: |
cargo build -p voicevox_core_java_api -vv
cargo build -p test_util -vv

@qryxip
Copy link
Member Author

qryxip commented Oct 26, 2023

あ、これ2行目でtest_utilを明示的に対象にしているのか。ならPythonでも同様にすればいい...?

@qryxip qryxip marked this pull request as draft October 26, 2023 20:14
@Hiroshiba
Copy link
Member

ちゃんとわかってないのですが、それに賛成です!!

@qryxip
Copy link
Member Author

qryxip commented Oct 26, 2023

- run: cargo build -p voicevox_core_c_api -vv

ここ、#239のときに入れたのですが、当時の状態を見ても何故これが必要だったのか正確に思い出せない... MaturinがmacOSとかで変なことになったような思い出があるのでそれか...?

とりあえずここを"voicevox_core_c_api" → "test_util"に変えてみます。

@qryxip
Copy link
Member Author

qryxip commented Oct 26, 2023

通った...
https://github.com/VOICEVOX/voicevox_core/actions/runs/6659635118?pr=659

ところでこの現状だと、dev-dependenciesに入れても意味をほとんど成しませんね。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants