downloadクレートをdownloaderクレートに #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Oct 16, 2023
There was a problem hiding this comment.
ドキュメントがdocs/downloads/download.mdの1ファイルで、vvm.mdはdocs直下にあるので、合わせてdownloader.mdを直下に置くようにしてみました。
ドキュメントの整理をする別の機会を設けて、その時に変更しても良いかも･･･？
Hiroshiba
changed the title
Hiroshiba
commented
Oct 16, 2023
| DLL用のヘッダファイルは [crates/voicevox\_core\_c\_api/include/voicevox\_core.h](https://github.com/VOICEVOX/voicevox_core/tree/main/crates/voicevox_core_c_api/include/voicevox_core.h) にあります。 | ||
| DLL 用のヘッダファイルは [crates/voicevox_core_c_api/include/voicevox_core.h](https://github.com/VOICEVOX/voicevox_core/tree/main/crates/voicevox_core_c_api/include/voicevox_core.h) にあります。 |
There was a problem hiding this comment.
あっ この辺変わっちゃいましたが、ま、まあ。。。
|
レビューありがとうございます！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
の解決プルリクエストです。
とりあえずやりやすかったのでdownloadバイナリもdownloaderに変えちゃいました。#607 (comment) の流れ次第ではdownloaderバイナリの名称を
downloadに戻しつつ、プルリクエストのタイトルを変更したいと思います。↑
こちらのコメントにある通り、バイナリの方は
downloadにしました。関連 Issue
close #607
その他
「
download([^e]|$)（downlaodが含まれ、後ろがeではないか、行末）」で検索して置き換えるかどうかを判断しました。githubのreleaseのURLに含まれている「download」や、ダウンロードするテストに含まれている「download」などはそのままにしています。