Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace.resolverを設定 #646

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Oct 15, 2023

内容

workspace rootでClippyなどを動かそうとしたときに出るこれを解消します。

warning: some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest

2で揃える利点としては、再ビルドの発生が減ることが期待できる点です。
(特に今の/crates/test_utilは問答無用で辞書(100MB)を再ダウンロードしたりするので)

関連 Issue

その他

@qryxip qryxip requested a review from Hiroshiba October 15, 2023 08:00
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

(何でvirual workspaceだけデフォルトが1なんだろう)

@Hiroshiba Hiroshiba merged commit 935468e into VOICEVOX:main Oct 15, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants