-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C API用のzipファイルからmodelディレクトリをなくし、別でmodelダウンロード可能にする #603
Merged
The head ref may contain hidden characters: "\u30B3\u30A2\u306Emodel\u30C7\u30A3\u30EC\u30AF\u30C8\u30EA\u3092\u5206\u96E2"
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
57212bb
modelのzipファイルをアップロード
Hiroshiba 0ef03a6
スクリプト版のダウンローダを消去する
Hiroshiba a6826cd
Merge branch 'スクリプト版のダウンローダを消去する' into コアのmodelディレクトリを分離
Hiroshiba 2359609
ダウンローダーの更新
Hiroshiba 887d615
modelディレクトリができてしまった
Hiroshiba 035d3b1
製品版のバージョンを変更
Hiroshiba 5ee41c4
Merge branch 'main' into コアのmodelディレクトリを分離
Hiroshiba 4548853
github.event.inputs→inputs
Hiroshiba 74ae74e
download_testをデフォルトでprerelease-latestが使われるように変更
Hiroshiba 2e93f10
Merge remote-tracking branch 'upstream/main' into コアのmodelディレクトリを分離
Hiroshiba 7889fa6
Merge remote-tracking branch 'upstream/main' into コアのmodelディレクトリを分離
Hiroshiba d5c370f
0.15.0-preview.2
Hiroshiba a948eb5
Merge remote-tracking branch 'upstream/main' into コアのmodelディレクトリを分離
Hiroshiba 936ad70
修正漏れ
Hiroshiba ee48bcb
cargo run -p download -- -h
Hiroshiba d014d31
Apply suggestions from code review
Hiroshiba 6bc9d62
変なとこが変わってた
Hiroshiba cee87ce
modelディレクトリのコピーが不要
Hiroshiba 95c8dcf
update VOICEVOX_FAT_RESOURCE_VERSION
Hiroshiba c504620
min指定時にmodelディレクトリは無いはず
Hiroshiba cbd3e5b
Merge remote-tracking branch 'upstream/main' into コアのmodelディレクトリを分離
Hiroshiba 4b755bc
--core_repo ${{ github.repository }}
Hiroshiba ee013d9
ミス
Hiroshiba 62b5584
&
Hiroshiba ed5c8a6
Update .github/workflows/download_test.yml
Hiroshiba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここを
repo: RepoName
にしたのはC-CALLER-CONTROLに従った結果だったのですが、まあどちらでも良いと思います。こういう考え方も主流ですし(というか私も普段書き殴るときはどちらかというとこっち側です)
https://twitter.com/qnighy/status/1008010536397651968
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あんま深いこと考えてなくて、
find_gh_asset
を2回呼ぶのでrepo
が移譲?されちゃって以降で使えなくなっちゃったんで&
つけた感じでした!