Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package.licenseと、LICENSEへのシンボリックリンク #32

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Sep 26, 2024

内容

以下の二つを行い、open_jtalkおよびopen_jtalk-sysBSD-3-Clauseであることを明確にします。

  1. package.license = "BSD-3-Clause"
  2. crates/{open_jtalk,open_jtalk-sys}にLICENSEへのシンボリックリンクを置く
    (cargo-denyやcargo-aboutなど、ライセンスを見る外部ツールのため)

2.はWindowsのworking directory上でどうなるかまだ確認していませんが、触らなければ大丈夫なはず?

関連 Issue

スクリーンショット・動画など

その他

@qryxip qryxip requested a review from Hiroshiba September 26, 2024 04:34
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ちょっとどうなるかわかってないけど)LGTM!!

@Hiroshiba
Copy link
Member

あ、テストが落ちちゃってそう

@qryxip qryxip changed the title add: package.licenseと、LICENSEへのシンボリックリンク fix: package.licenseと、LICENSEへのシンボリックリンク Oct 14, 2024
@qryxip qryxip force-pushed the add-add-package-licenses-and-symlinks-to-license-file branch from 33facdf to cee3821 Compare December 4, 2024 19:16
@qryxip qryxip merged commit 7c87b42 into VOICEVOX:main Dec 4, 2024
38 checks passed
qryxip added a commit to VOICEVOX/voicevox_core that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants