Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe impl Send for {Mecab,Njd,JpCommon} #31

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Apr 2, 2024

内容

COREの以下の部分の役目を、こちら側に移します。

https://github.com/VOICEVOX/voicevox_core/blob/fa630ce9596103e00b78049bf5c0db0e078c125e/crates/voicevox_core/src/engine/open_jtalk.rs#L185-L187

関連 Issue

スクリーンショット・動画など

その他

qryxip added a commit to qryxip/voicevox_core that referenced this pull request Apr 2, 2024
@qryxip qryxip requested a review from Hiroshiba April 5, 2024 02:51
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit e1940f3 into VOICEVOX:main Apr 14, 2024
18 checks passed
qryxip added a commit to qryxip/voicevox_core that referenced this pull request Apr 16, 2024
Hiroshiba pushed a commit to VOICEVOX/voicevox_core that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants