-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework scenario duplication #144
Open
iripiri
wants to merge
22
commits into
master
Choose a base branch
from
rework_scenario_duplication
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iripiri
commented
Aug 30, 2024
- Add usergroups via API (before: groups.yaml)
- Add users to usergroup via API
- Duplicate scenario(s) for user when adding to a usergroup (before: when using external authentication)
Signed-off-by: iripiri <[email protected]>
Signed-off-by: iripiri <[email protected]>
7 tasks
… to usergroup Signed-off-by: iripiri <[email protected]>
Signed-off-by: iripiri <[email protected]>
Open TODOs:
|
@iripiri Is it ok to set up another branch and work there ? i don't think you would want things to be merged immediately |
SystemsPurge
force-pushed
the
rework_scenario_duplication
branch
from
October 15, 2024 12:24
2d0da06
to
3591f46
Compare
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
SystemsPurge
force-pushed
the
rework_scenario_duplication
branch
from
October 15, 2024 17:27
c02f3f2
to
7197fac
Compare
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
SystemsPurge
force-pushed
the
rework_scenario_duplication
branch
from
October 16, 2024 09:37
49abc9b
to
8da1b1f
Compare
Signed-off-by: SystemsPurge <[email protected]>
Should deleting a usergroup also remove access of users to the non-duplicate scenarios ? And if so, should we go all the way checking whether another usergroup is giving said users access to the same scenario ? |
…tionship with usergroups Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
al3xa23
approved these changes
Oct 22, 2024
Signed-off-by: SystemsPurge <[email protected]>
Signed-off-by: SystemsPurge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.