Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework scenario duplication #144

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Conversation

iripiri
Copy link
Contributor

@iripiri iripiri commented Aug 30, 2024

  • Add usergroups via API (before: groups.yaml)
  • Add users to usergroup via API
  • Duplicate scenario(s) for user when adding to a usergroup (before: when using external authentication)

@iripiri
Copy link
Contributor Author

iripiri commented Oct 9, 2024

Open TODOs:

  • remove reading in groups from groups.yaml (affected: start.go, config.go, user_test.go, authenticate_endpoint.go)
  • rewrite the test TestUserGroups in user_test.go
  • delete duplicated scenario when user is removed from usergroup (usergroup_endpoints.go)
  • make sure all duplicated scenarios are deleted when an entire usergroup is deleted
  • Update scenarios on mapping update ( e.g delete duplicates if scenario with duplicate = true is removed from mapping )
  • write tests for the functionialities in the two points above (usergroup_test.go)

@SystemsPurge @Anyandsi @al3xa23

@SystemsPurge
Copy link

@iripiri Is it ok to set up another branch and work there ? i don't think you would want things to be merged immediately

@SystemsPurge SystemsPurge self-assigned this Oct 10, 2024
@SystemsPurge SystemsPurge force-pushed the rework_scenario_duplication branch from 2d0da06 to 3591f46 Compare October 15, 2024 12:24
@SystemsPurge SystemsPurge force-pushed the rework_scenario_duplication branch from c02f3f2 to 7197fac Compare October 15, 2024 17:27
@SystemsPurge SystemsPurge force-pushed the rework_scenario_duplication branch from 49abc9b to 8da1b1f Compare October 16, 2024 09:37
@SystemsPurge
Copy link

Should deleting a usergroup also remove access of users to the non-duplicate scenarios ? And if so, should we go all the way checking whether another usergroup is giving said users access to the same scenario ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants