Add a matcher for OS IP devices and IPs on a FPGA #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Bauer <[email protected]>
n-eiling
requested changes
Nov 21, 2024
| #include <villas/fpga/core.hpp> | ||
| #include <villas/kernel/devices/ip_device.hpp> | ||
|
|
||
| class DeviceIpMatcher { |
There was a problem hiding this comment.
Why create a class? A function would be enough right?
|
|
||
| std::vector<std::pair<std::shared_ptr<villas::fpga::ip::Core>, | ||
| villas::kernel::devices::IpDevice>> | ||
| match() const { |
There was a problem hiding this comment.
This doesn't look correctly formatted. Please check your clang-format configuration
stv0g
changed the title
Co-authored-by: Niklas Eiling <[email protected]> Signed-off-by: IgnoreWarnings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match ip devices on os level with ips on the fpga based on memory address.