-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for FPGAs connected via the vfio-platform driver #783
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a first round of review. I will need to go a bit deeper into the actual logic.
Some general things:
- Please reformat all your changes with clang-format
- Make sure your comments have a DCO sign-off (the CI check is failing)
- Please try to consolitate/stash your commits in a way it makes the code easier to review. E.g. not everything into one commit, but smaller groups of changes which are logically belong together.
This is just a draft to track the progress. It's clear that it needs squashing, signing-off and formatting. It may also make sense to split it into multiple PRs. |
Oh okay, sorry I did not see that this PR was a draft. |
I accidentally opened a PR at first and then changed to draft. Since this is work in progress, many of the changes requested are already outdated/fixed. |
5b5091e
to
e2cd4d8
Compare
ef5fd45
to
45f732b
Compare
fpga/lib/ips/zynq.cpp
Outdated
// Save ID in card so we can create mappings later when needed (e.g. when | ||
// allocating DMA memory in host RAM) | ||
card->addrSpaceIdDeviceToHost = | ||
mm.getOrCreateAddressSpace("zynq_ultra_ps_e_0/HPC0_DDR_LOW"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be hardcoded?
6a5ec9d
to
5f3568c
Compare
d8ddbb4
to
1ebb82c
Compare
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Niklas Eiling <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
DO NOT MERGE!
This is a draft only to discuss and track progress. Changes will come in smaller PRs.
Integration of platform based fpgas.