ViewPager2 performance regressions #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will probably re-introduce bugs when the number of episodes changes (?), but this is worth the trade-off of much better paging performance.
UweTrottmann
force-pushed
the
viewpager2-perf-regressions
branch
from
6d61534 to
6af22f6
Compare
|
Switching back. Not seeing any reason to stick with v2 and the paging performance is just so much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewPager2 performance is really bad. Doing a quick trace shows the issue is layouts getting inflated a lot. Maybe this can be tweaked by parameters?
offscreenPageLimit = 1improves things a bit, but still not even close to v1 performance.This experimentally switches the episode pager back to the v1 implementation as the v2 one is not really actively developed despite promises. Were there any issues that warranted switching to v2 (e.g. when the amount of pages changed)?