YDA-5415: improve revision cleanup stability #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsnel
force-pushed
the
yda-5415-revision-cleanup-scan-scalability
branch
3 times, most recently
from
3f38922 to
0ab086b
Compare
stsnel
force-pushed
the
yda-5415-revision-cleanup-scan-scalability
branch
2 times, most recently
from
154f997 to
6b75eb8
Compare
lwesterhof
approved these changes
Oct 25, 2023
This modifies the revision cleanup process, so that the scan stage (collecting data about revisions) is separate from the collect stage (collecting a list of all revisions). Scanning revision data is done in batches now, rather than a one-time scan for the whole environment. This reduces the amount of memory needed for the scan stage, which contributes to making the revision cleanup job usable on large environments.
stsnel
force-pushed
the
yda-5415-revision-cleanup-scan-scalability
branch
from
6b75eb8 to
7811bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the revision cleanup process, so that the scan stage (collecting data about revisions) is separate from the collect stage (collecting a list of all revisions). Scanning revision data is done in batches now, rather than a one-time scan for the whole environment.
This reduces the amount of memory needed for the scan stage, which contributes to making the revision cleanup job usable on large environments.