YDA-4101: add ability to create external user with custom creator #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravox
commented
Oct 5, 2023
Comment on lines
+463
to
+481
| # \brief Get a list of both manager and non-manager members of a group. | ||
| # | ||
| # This function ignores zone names, this is usually a bad idea. | ||
| # | ||
| # \deprecated Use uuGroupGetMembers(*groupName, *includeRo, *addTypePrefix, *members) instead | ||
| # | ||
| # \param[in] groupName | ||
| # \param[out] members a list of user names | ||
| # | ||
| uuGroupGetMembers(*groupName, *members) { | ||
| uuGroupGetMembers(*groupName, false, false, *m); | ||
| *members = list(); | ||
| foreach (*member in *m) { | ||
| # Throw away the zone name for backward compat. | ||
| uuChop(*member, *name, *_, "#", true); | ||
| *members = cons(*name, *members); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Added back this function so that --delete and --allow-update options in yoda-clienttools would still work. Otherwise we do not use this function.
stsnel
reviewed
Oct 6, 2023
stsnel
requested changes
Oct 6, 2023
stsnel
approved these changes
Oct 9, 2023
claravox
force-pushed
the
YDA-4101-create-external-user-behalf
branch
from
53662fa to
dafe7da
Compare
claravox
force-pushed
the
YDA-4101-create-external-user-behalf
branch
from
dafe7da to
b14bfe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires UtrechtUniversity/yoda-clienttools#5