Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YDA-5664: fix delete API call that had no effect #18

Merged
merged 1 commit into from
Apr 26, 2024
Merged

YDA-5664: fix delete API call that had no effect #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions yoda_eus/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ def delete_user() -> Response:
if len(UserZone.query.filter_by(user_id=user.id).all()) == 0:
User.query.filter_by(username=content['username']).delete()

db.session.commit()

# Return result
response = {"status": "ok", "message": "User {} deleted from zone {}.".format(content["username"],
content["userzone"])}
Expand Down
6 changes: 6 additions & 0 deletions yoda_eus/tests/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ def test_add_and_remove_user_once(self, test_client):
assert response1.status_code == 201
response2 = c.post('/api/user/delete', json=rm_params, headers=auth_headers)
assert response2.status_code == 204
# This delete call is to verify that the user is really gone
response3 = c.post('/api/user/delete', json=rm_params, headers=auth_headers)
assert response3.status_code == 404

def test_add_and_remove_user_twice(self, test_client):
auth_headers = {'X-Yoda-External-User-Secret': 'dummy_api_secret'}
Expand All @@ -87,6 +90,9 @@ def test_add_and_remove_user_twice(self, test_client):
assert response3.status_code == 204
response4 = c.post('/api/user/delete', json=rm2_params, headers=auth_headers)
assert response4.status_code == 204
# This delete call is to verify that the user is really gone
response5 = c.post('/api/user/delete', json=rm2_params, headers=auth_headers)
assert response5.status_code == 404

def test_forgot_password_show_form(self, test_client):
with test_client as c:
Expand Down