Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix software deletion from UI #90

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix software deletion from UI #90

merged 1 commit into from
Aug 27, 2024

Conversation

tsagadar
Copy link
Collaborator

UI sends array of IDs as the payload, but backend expected object with files property. Files is not a good naming, so adjusted backend.

UI however should always call the BFF, so some more work required. Not creating a test case for this issue before this bigger refactoring.

Fixes #89

UI sends array of IDs as the payload, but backend expected object with files
property. Files is not a good naming, so adjusted backend.

UI however should always call the BFF, so some more work required. Not creating
a test case for this issue before this bigger refactoring.
Copy link
Contributor

@b-rowan b-rowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we want to go the RootModel route, we will have to make that decision later. For now this should be fine.

@b-rowan b-rowan merged commit 118d176 into master Aug 27, 2024
2 checks passed
@b-rowan b-rowan deleted the mm/fix-software-deletion branch August 27, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Software enty (for external artifact) cannot be deleted
2 participants