Making update mechanism more robust #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an edge case, the software can be deleted while device reboots after update. This caused errors and endless reporting of device.
tsagadar
force-pushed
the
mm/increase-update-reporting-robustness
branch
from
56a9f95 to
a8bf154
Compare
b-rowan
requested changes
Dec 1, 2024
| async def _assertLogLines(device, expected_line_count): | ||
| persisted_device = await Device.get(uuid=device.uuid) | ||
| log = persisted_device.last_log | ||
| async def _assertLogLines(async_client, device, expected_line_count): |
There was a problem hiding this comment.
This should be named _assert_log_lines to keep with Python naming conventions.
tsagadar
force-pushed
the
mm/increase-update-reporting-robustness
branch
from
a8bf154 to
6e41625
Compare
b-rowan
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an edge case when deleting software/rollout before the last device reported back.
Second improvement: use API to get logs in test and don't directly access db.