Remove WebSockets #213
Merged
Remove WebSockets #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UpstreamData
force-pushed
the
remove_ws
branch
2 times, most recently
from
7de26a3 to
920a94b
Compare
tsagadar
requested changes
Nov 26, 2024
There was a problem hiding this comment.
These changes should allow to do even further cleanups:
- remove websockets from pyproject.toml
- remove realtime being mentioned in documentation
- simplify device_manager.py: no need to have state
_log_subscriptions
Not sure if there is even more, but looks great to be able to simplify the code substantially.
UpstreamData
force-pushed
the
remove_ws
branch
from
5c87b05 to
95dcad3
Compare
tsagadar
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #198