Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto assign milestone to PR or issue based on tag #115

Closed
wants to merge 1 commit into from

Conversation

b-rowan
Copy link
Contributor

@b-rowan b-rowan commented Sep 3, 2024

Assigns a milestone to an issue or PR automatically when a tag matching a v*.*.* semantic version is added.

@b-rowan b-rowan added the enhancement New feature or request label Sep 3, 2024
@b-rowan b-rowan requested a review from tsagadar September 4, 2024 04:58
Assigns a milestone to an issue or PR automatically when a tag matching a `v*.*.*` semantic version is added.
@tsagadar
Copy link
Collaborator

tsagadar commented Sep 4, 2024

I am not that familiar with this. My current understanding is that these actions will automatically assign/unassign issues/PRs to milestones if a label is used matching a version? Shouldn't we just directly set those milestones instead of labels (personally I was not that aware about milestones, but sure the better approach).

What confused me initially was the term "tag". So I assumed git tags. Maybe better to use label?

@b-rowan
Copy link
Contributor Author

b-rowan commented Sep 4, 2024

I am not that familiar with this. My current understanding is that these actions will automatically assign/unassign issues/PRs to milestones if a label is used matching a version? Shouldn't we just directly set those milestones instead of labels (personally I was not that aware about milestones, but sure the better approach).

I sort of agree, but the tagging system is a bit nicer to work with I think. Basically the goal of this PR is to use tags to synchronize with milestones, as milestones seem to track progress better, but tags are easier to assign and work with. We create the tags and then the rest gets automated.

If the consensus is a preference of milestone only for versions, I'm ok with that too, but this actually seemed less confusing to me.

What confused me initially was the term "tag". So I assumed git tags. Maybe better to use label?

Yeah, this makes sense. I was a bit confused too when I wrote this, I'll swap everything over to labels tomorrow.

@easybe
Copy link
Collaborator

easybe commented Sep 4, 2024

If the consensus is a preference of milestone only for versions, I'm ok with that too, but this actually seemed less confusing to me.

Yes, we should use milestones instead of labels for versions, because that is what the feature is for. Even though I was aware of milestones, I started using labels because it was the easiest at the time.

IMHO we should only introduce a new CI job (and complexity) if there is an actual problem to solve.

@b-rowan b-rowan closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants