-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
062 migrate to layout #93
Conversation
Also add mt-unheader tailwind style to move background components behind the header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I am just wondering whether it would be possible to have the footer moved up slightly on the 404 not found page? (See vid - at the moment you have to scroll to see the footer, which is maybe a bit odd given that the 404 page doesn't really have any content to justify the footer being off the bottom of the page?). I am happy to have a go at this but honestly not sure I'll know how to...
Recording.2024-08-06.112234.mp4
Ah! Don't worry about that that's just Next's default 404 page (which we can't really change). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Context
We want to have a consistent page layout for each page.
Closes #62
What Changed?
<Header />
and<Footer />
components from each individual pagelayout.tsx
layout.tsx
<main />
(which is now a column flexbox)How To Review
layout.tsx
and the home pagepage.tsx
pages firstNotes
*New tailwind styles:
mt-header
andpt-header