Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

135 make website dynamic #147

Merged
merged 11 commits into from
Oct 21, 2024
Merged

135 make website dynamic #147

merged 11 commits into from
Oct 21, 2024

Conversation

h4yleysh4rpe
Copy link
Contributor

Context

Making pages dynamic to different screen sizes, and also to different images being put into Strapi.

Closes #135

What Changed?

Changed heaps of stuff to render conditionally on screen sizes - including but not limited to header sizes, projects page timeline now working for narrow phones, members page chair arrow/fun facts showing for various widths and for various image dimensions, Home page blobs are connected on all screen widths and centred for small screen widths

How To Review

  • Look at members, home, feedback/FAQ, about us and projects, specifically for the things above but also keep an eye out otherwise for anything else that should be dynamic. Check that all sizes of screen are reasonable and nothing looks weird. Ignore any carousel components, the horizontal timeline on the about us page, the value cards on about us, and modals that pop up - these will be sorted on other tickets.
  • Please put diff sizes/ratios of images in Strapi and check that the chair arrows still point (more or less) to each chair, and that they are not off the edge of the page. This is the main thing that might go weird so be sure to check it

Notes

Branch is 135_make-website-dynamic not make-pages-dynamic

Copy link

@YvonneLiew YvonneLiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@panmann7 panmann7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good!!

@panmann7 panmann7 merged commit f6df90e into main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pages dynamic
5 participants