Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

104 Convert Chairperson Image to Text #118

Merged
merged 2 commits into from
Oct 2, 2024
Merged

104 Convert Chairperson Image to Text #118

merged 2 commits into from
Oct 2, 2024

Conversation

eilecn
Copy link
Contributor

@eilecn eilecn commented Sep 3, 2024

Context

  • Originally the the arrows and fun facts on the members pages pointing to the chairperson images were images
  • Fixed it so that the arrow is an image and the fun fact itself is modifiable text

Closes #104

What Changed?

  • Edited the arrow images to crop out the existing fun fact text
  • Implemented fun fact text from strapi onto the page
  • Aligned the image and text to point at the chairperson images

How To Review

  • Head over to the members page and check that the arrows pointing to the chairperson image are images, and the fun fact text is text
  • Check that the fun fact text is modifiable through strapi
  • Checkout next/components/members/Chairman.tsx to review the changes

h4yleysh4rpe
h4yleysh4rpe approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@h4yleysh4rpe h4yleysh4rpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

YvonneLiew
YvonneLiew reviewed Sep 16, 2024
View reviewed changes
Copy link

@YvonneLiew YvonneLiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Oculux314
Oculux314 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@Oculux314 Oculux314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving an official approval for Yvonne's review so this can be merged :)

@Oculux314 Oculux314 merged commit 56a25a6 into main Oct 2, 2024
@Oculux314 Oculux314 deleted the 104_convert_chairperson-image-to-text branch October 2, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YvonneLiew YvonneLiew YvonneLiew left review comments

@h4yleysh4rpe h4yleysh4rpe h4yleysh4rpe approved these changes

@Oculux314 Oculux314 Oculux314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Chairperson Image to Text
4 participants
@eilecn @YvonneLiew @Oculux314 @h4yleysh4rpe