-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
01 navbar #41
base: main
Are you sure you want to change the base?
Conversation
Looks good! 🔥 Few questions from me:
|
RE: @raymondyangdev
2.) Yes, I have not done that, if its an easy fix then it would be great if you could implement that on a single commit and i can steal the process for the footer branch :33 |
Integrated Strapi to our Navbar 🚀 In Strapi dashboard, I've added the following:
The footer can go in there and anything else that is rendered across the app that is not page/component specific 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty swick!
Just have a few queries before approving:
- Logo is optional in Strapi but crashes the page if it doesn't exist
- If I upload any image format other than large, the page crashes
- Consider using usePathname instead of window.location.pathname
- For openMenu and closeMenu, I think you don't actually need to disable scrolling! Also, I think it might be better to use state to control the flex/none state of hamburg-options, rather than using querySelector.
- Love the mobile/desktop view comments, but if you need them consider if maybe they'd be better off as their own components
- New pages might conflict with other pages - would recommend deleting before merging
I like that it doesn't crash if there are no links. Also, the conditional tailwind is pretty cool, and I like the design.
P.s. Raymond I appreciate how modular the global Strapi component is 👍
Context
Implements a navbar to be rendered on all pages of the website.
Closes #4
What Changed?
We did the following...
How To Review
Testing
UI Testable when testing framework implemented.
Notes