-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vol 26/discover tab #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
web/src/pages/MainMenu.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't commit this file, since your component would go on the Dashboard page (which hasn't been made yet) and not the MainMenu page. It's ok to use it to preview your component though. Could you edit your commit so it does not include this file? After that its all ok to merge, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't commit your changes to MainMenu.tsx, since you're just using that to preview your component. After that, you are good to merge :))
Fixed the container css in discovery, complete the discovery tab.