Gh110 integrating timer for pop up #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes
What Changed?
How To Review
Testing
If theres an event that STARTS in 7 days then it should popup at the start of the session.
and then it wont popup again, so you can go between pages and back to the passport page and it wont show up again.
Items in sessionStorage decay (get deleted) if you close the tab, so if you close the tab and re-open it, the notification will show up again.
Risks
I've put the check thingy inside one of the useEffect hooks, and the hook is being run twice (idky), so if you close the notification too quickly, there's a chance it'll show up again, this only happens the first time you enter the passport page and close the notification straight away. It wont re-appear more than twiceeee.
Notes