Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Play Page UI Fixes #261

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Minor Play Page UI Fixes #261

merged 3 commits into from
Oct 20, 2024

Conversation

harbassan
Copy link
Contributor

Describe the issue

Fix 1:

Changed the colours for the play page side menu tooltips, from a transparent to a black:

image
vs

image

Fix 2:

Changed the background of the main play page from a light grey to white, to reflect the same colours used in the authoring tool.

image
image

Risk

No risks

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

@harbassan harbassan changed the title Minor UI Fixes Minor Play Page UI Fixes Oct 20, 2024
Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a single potential finding :)

frontend/src/index.css Outdated Show resolved Hide resolved
Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@harbassan harbassan merged commit 6278390 into master Oct 20, 2024
5 checks passed
@harbassan harbassan deleted the minor-ui-fixes branch October 20, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants