[VPS-30] Thumbnail Images #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjin-lee
approved these changes
Aug 31, 2024
frontend/src/containers/pages/AuthoringTool/Components/ThumbImage.jsx
Outdated
Show resolved
Hide resolved
| @@ -37,76 +37,17 @@ exports[`ListContainer component snapshot test 1`] = ` | |||
| <div | |||
| className="MuiBox-root MuiBox-root-2" | |||
| > | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue
Thumbnail images use iframes that load really slowly and dont show the correct content due to the way the routing has changed.
Describe the solution
Replaced iframes with dynamically generated svg elements. They use a seperate resolver structure to map the scene components to various elements that are placed within a single svg, which means they are completely resizable and look the same at all sizes, which is good for our use case.
New Thumnail:
Risk
No risks
Definition of Done
Reviewed By
Who reviewed your PR - for commit history once merged