Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vps 46/linking resources to flags #225

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Conversation

Kot6603
Copy link
Contributor

@Kot6603 Kot6603 commented Aug 30, 2024

Describe the issue

When we navigate between scenes, we don't know which resources are visible to that group at that point in time.

Describe the solution

  • When we reset the scenario, the current flags field in the group schema is updated to an empty list.
  • When the scene change happens, the API endpoint to get the list of visible resources is called.
  • A new API endpoint was added at /api/navigate/group/resources/:groupId to get the list of currently visible resources for that group.

TODO:

  • the logic for adding the visible resources to the list needs to be implemented (currently returns just an empty list)

Risk

  • Could break scene crawling

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

@Kot6603 Kot6603 requested a review from wjin-lee August 30, 2024 01:12
Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kot6603 Kot6603 merged commit e075b3c into master Aug 30, 2024
6 checks passed
@Kot6603 Kot6603 deleted the VPS-46/linking-resources-to-flags branch August 30, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants